Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reformat Python code with line length = 88 #2056

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: reformat Python code with line length = 88 #2056

merged 1 commit into from
Nov 13, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Nov 12, 2024 •
edited
Loading

This PR reformats Python code with a maximum line length of 88 characters to better represent the code. Note that a related repo MODFLOW-USGS/modflow6-examples already uses the default line length of 88.

See modflowpy/flopy#2362 for a related PR with rational and discussion.

This PR was automated using these Ruff commands (including quick fixes to ISC001):

ruff format
ruff check --select ISC001 --fix
ruff format

wpbonelli
wpbonelli approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can eventually look into removing ignored rules here too

@mwtoews
Copy link
Contributor Author

mwtoews commented Nov 12, 2024

A follow-up PR could look at relaxing some ignored rules, as well as adding a .git-blame-ignore-revs file.

@wpbonelli wpbonelli merged commit f6c3a55 into MODFLOW-USGS:develop Nov 13, 2024
26 checks passed
@mwtoews mwtoews deleted the line-length-88 branch November 13, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpbonelli wpbonelli wpbonelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwtoews @wpbonelli